Exclude one auction which has faulty score data #326
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
excludes hash `0xd881e90f4afb020d92b8fa1b4931d2352aab4179e4f8d9a4aeafd01ebc75f808`
bh2smith
approved these changes
Dec 14, 2023
| @@ -17,6 +17,7 @@ batch_meta as ( | |||
| where b.block_time between cast('{{StartTime}}' as timestamp) and cast('{{EndTime}}' as timestamp) | |||
| and (b.solver_address = from_hex('{{SolverAddress}}') or '{{SolverAddress}}' = '0x') | |||
| and (b.tx_hash = from_hex('{{TxHash}}') or '{{TxHash}}' = '0x') | |||
| and (b.tx_hash !=0xd881e90f4afb020d92b8fa1b4931d2352aab4179e4f8d9a4aeafd01ebc75f808) | |||
There was a problem hiding this comment.
ubernit:
Suggested change
| and (b.tx_hash !=0xd881e90f4afb020d92b8fa1b4931d2352aab4179e4f8d9a4aeafd01ebc75f808) | |
| and (b.tx_hash != 0xd881e90f4afb020d92b8fa1b4931d2352aab4179e4f8d9a4aeafd01ebc75f808) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just excludes the auction with hash
0xd881e90f4afb020d92b8fa1b4931d2352aab4179e4f8d9a4aeafd01ebc75f808from the slippage accounting.This was done as a quick fix to work around wrong data on fees in our database.
I am mostly posting this here so we can keep track of which versions of the slippage query have been used for payments.